发表于: 2017-12-31 19:03:06
1 659
今日完成:
为所有的接口打了日志,加了注释。然后根据前端要求改接口。
明日计划:
看一下怎么提升性能,但是是因为数据量大所以速度慢,明天看看返回少一点数据,或者添加缓存。
成果:
//修改用户信息
@RequestMapping(value = "/a/u/user/{id}", method = RequestMethod.PUT)
public String updateUserJson(HttpServletRequest request,
HttpServletResponse response, ModelMap model,@PathVariable Long id,String userName,Long roleId,String roleName,String oldPwd,String newPwd,Long phone) throws Exception {
log.info("update user : id= " + id);
try {
User user=userService.getObjectById(id);
if(userName!=null){
user.setUserName(userName);
log.info("update user : id= " + id+"'s userName to "+userName);
}
if(roleId!=null&&roleName!=null){
user.setRoleId(roleId);
user.setRoleName(roleName);
log.info("update user : id= " + id+"'s roleId and roleName to "+roleId+" "+roleName);
}
if(newPwd!=null&&oldPwd!=null){
if (user.getPassword()==oldPwd){
user.setPassword(newPwd);
log.info("update user : id= " + id+"'s password to "+newPwd);
}
if (phone!=null&&userService.getUserIdByPhoneAndPassword(phone,oldPwd)!=null){
user.setPassword(newPwd);
log.info("update user : id= " + id+"'s password to "+newPwd);
}
userService.update(user);
log.info("successfully update user : id = "+id);
model.addAttribute("code", 0);
model.addAttribute("user", user);
} catch (Throwable t) {
t.printStackTrace();
log.error(t.getMessage());
log.error("update user error,id is " + id);
model.addAttribute("code", -6003);
}
return "pagescarrots-youneedboy-user-service/data/json";
}
这样打日志符合标准吗?因为这个逻辑很简单,一眼就能看懂含义就没加注释,在逻辑较复杂的有加注释。
还有统计性能的是自己打日志来统计性能还是直接jmeter性能检测通过了就行?
动态查询的工具类。其中需要注意的是string类型的模糊查询用"type & like"," '%"+type+"%'"
相等的用("type",type),搞混了的话就会报错。
public static Map<String,Object> companyDynamicSearch(String name, Integer industry, Long city,
String productName, Integer financing, Integer identify, Integer forzen){
Map<String,Object> param=new HashMap<String, Object>();
if (name!=null){
param.put("name & like"," '%"+name+"%'");
}
if (industry!=null){
param.put("industry",industry);
}
if (city!=null){
param.put("city",city);
}
if (productName!=null){
param.put("product_name & like"," '%"+productName+"%'");
}
if (financing!=null){
param.put("financing",financing);
}
if (identify!=null){
param.put("identify",identify);
}
if (forzen!=null){
param.put("forzen",forzen);
}
param.put("@order","create_at desc");
param.put("@table","company");
return param;
}
进度:
基本完成代码整洁化,下一步优化性能。
禅道:
http://task.ptteng.com/zentao/my-task.html
评论